Adding kafka properties to KafkaProtobufDeserializer. #1934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding kafka properties to KafkaProtobufDeserializer, to be able to execute schema registry rules.
In class:
AbstractKafkaSchemaSerDe
, methodprotected Object executeRules
, line 671config.originals()
will throw a null pointer exception and fail the deserialization.Not sure if my fix is the best way, I guess maybe a method that takes all the kafka properties from both kafka and the schema registry including the URL and username/password with the default key that are defined in the
connection
configuration?