-
Notifications
You must be signed in to change notification settings - Fork 132
Added ability to use additional optimizers #166
base: master
Are you sure you want to change the base?
Conversation
To add the ability to use additional optimizers without editing the core loader, I have added the option additionalPlugins to the loader options. Using this, a user can define an additional imagemin plugin to use, along with it's options, and the loader will utilize that optimizer as well (as long as it is installed as a node module).
sorry for the late review. Can you add a test where you add an additional optimizer? |
I think this is good. |
A follow-up PR with tests would be ok. |
aah...I cant fork his repo and keeping my existing fork. I guess you can merge this and I will add tests |
I am active enough, I will accept any PRs towards my repo. I just never had
time to write tests for this.
|
Ohh...I saw your GH contribution graph and thought of that. Nevermind. Will submit a PR in your fork soon |
Sounds good! I'll keep an eye out for a PR. I am only contributing to private repos right now, but I do want to get back into open source development. |
Great to hear that 👍 |
chore(test): added tests for additional plugin feat
Can the conflicts be resolved? |
@ShawnCorrigan after rebasing , you need to update the |
Okay I will get to this tonight after work |
Cc @ShawnCorrigan |
To add the ability to use additional optimizers without editing the core loader, I have added the option additionalPlugins to the loader options. Using this, a user can define an additional imagemin plugin to use, along with it's options, and the loader will utilize that optimizer as well (as long as it is installed as a node module).