♻️ Refactor RegisterTable usage: remove redundant editable prop and e…

…nhance prop type definitions
tcorzo · Nov 7, 2024 · a80002e · a80002e
1 parent a2e6b2c
commit a80002e
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 11 deletions.
diff --git a/src/components/Editor.vue b/src/components/Editor.vue
@@ -10,9 +10,9 @@ const globalState: GlobalState = inject('globalState') || {} as GlobalState;
 <template>
   <div id="editor">
     <OperationsTable />
-    <RegisterTable :editable="true" :title="'Registros Auxiliares'" :registers="globalState.program.aux_registers" />
-    <RegisterTable :editable="true" :title="'Program'" :registers="globalState.program.registers" />
-    <RegisterTable :editable="true" :title="'Data'" :registers="globalState.program.data_registers" />
+    <RegisterTable editable :title="'Registros Auxiliares'" :registers="globalState.program.aux_registers" />
+    <RegisterTable editable :title="'Program'" :registers="globalState.program.registers" />
+    <RegisterTable editable :title="'Data'" :registers="globalState.program.data_registers" />
   </div>
 </template>
 

diff --git a/src/components/RegisterTable.vue b/src/components/RegisterTable.vue
@@ -28,14 +28,23 @@
 </template>
 
 <script setup lang="ts">
-import { ref } from 'vue';
+import { PropType, ref } from 'vue';
 import { Register } from './../abacus/program';
 
-const props = defineProps<{
-    title: string
-    registers: Register[],
-    editable: boolean
-}>()
+const props = defineProps({
+    title: String,
+    registers: {
+        type: Array as PropType<Register[]>,
+        required: true
+    },
+    editable: {
+        type: Boolean,
+        required: false,
+        default(_: any) {
+            return false;
+        }
+    }
+})
 
 const editMode = props.editable ? 'cell' : undefined
 

diff --git a/src/components/emulator/AuxRegisters.vue b/src/components/emulator/AuxRegisters.vue
@@ -16,7 +16,7 @@ const registers = computed(
 </script>
 
 <template>
-    <RegisterTable :editable="false" :title="'Registros Auxiliares'" :registers="registers" />
+    <RegisterTable :title="'Registros Auxiliares'" :registers="registers" />
 </template>
 
 <style scoped>

diff --git a/src/components/emulator/DataRegisters.vue b/src/components/emulator/DataRegisters.vue
@@ -17,7 +17,7 @@ const registers = computed(() => {
 </script>
 
 <template>
-    <RegisterTable :editable="false" :title="'Data'" :registers="registers" />
+    <RegisterTable :title="'Data'" :registers="registers" />
 </template>
 
 <style scoped>