Skip to content

Commit

Permalink
refactor - removeProvider update to use id
Browse files Browse the repository at this point in the history
  • Loading branch information
hanrw committed Aug 24, 2024
1 parent 9386056 commit 906e8f3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ interface OpenAIGateway : Chat, Completions {
)

fun addProvider(provider: OpenAIProvider): OpenAIGateway
fun removeProvider(name: String)
fun removeProvider(id: String)
fun getProviders(): List<OpenAIProvider>
}
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ class DefaultOpenAIGateway(
return this
}

override fun removeProvider(name: String) {
availableProviders.removeAll { it.name == name }
override fun removeProvider(id: String) {
availableProviders.removeAll { it.id == id }
}

override fun getProviders(): List<OpenAIProvider> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class DefaultOpenAIGatewayTest {

@Test
fun `should able to remove provider`() {
openAIGateway.removeProvider(anthropic.name)
openAIGateway.removeProvider(anthropic.id)
// Then
assertEquals(3, openAIGateway.getProviders().size)
assertEquals(azure, openAIGateway.getProviders().last())
Expand Down

0 comments on commit 906e8f3

Please sign in to comment.