Open
Conversation
This gets rid of annoying VS2017 files in our tracked changes
…ptions to test across the whole spectrum Because test discovery and execution works a little different in modern visual studio, we have to remove the old strong dependencies onto NUnit. The test project also doesn't have to be an executable anymore - with the new TestAdapter system we can just add the NUnit and NUnit3TestAdapter packagereference and the dotnet-sdk/cli and visual have everything they need. For all this to work together a little more nicely i also migrated the solution file to the VS2017 schema.
…argeted options to allow for usage in netstandard2.0 and .NET Full Framework 4.0+ With the dotnet cli/sdk installed you don't need the nuspec anymore. everything works inside the CSProj. You just "dotnet pack" and the package builds with dependencygroups for all target frameworks listed in the <targetframeworks> property. NuGet depecrated the owners attribute, which is why it did not move into the csproj everything else is pretty copypasta'd from the nuspec into the csproj. The AssemblyInfo is removed because sdk-based csproj builds autogenerate these based on the Version information inside the csproj (which is better because in our example we already see the issues of multiple sources of truth; the AssemblyInfo says version 1.1.0.0 and the nuspec says 1.2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a general overhaul of the project files and a move to support .NET Standard Projects as well as the existing .NET 4.0.
This would also resolve #2