Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change div.clickable to a[href] #411

Closed
wants to merge 2 commits into from
Closed

change div.clickable to a[href] #411

wants to merge 2 commits into from

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jul 7, 2016

There are no other occurences of data-href in the whole project

closes #409

fixes #398

@Haroenv
change div.clickable to a[href]
7638ff6 
There are no other occurences of `data-href` in the whole project

closes #409

fixes #398
@thgh
Copy link
Contributor

thgh commented Jul 7, 2016

There are still some issues:

  • Merge conflict in home.blade.php, this is because the homepage uses Vue.js for facet filtering, the clickable-row to replace is now in Dataset.vue. Run gulp to compile the js.
  • The clickable-row in the admin is not replaceable because it contains other links, <a> cannot be nested.
  • The titles of the rows are links. These links have to be removed, also because it's not nestable.

@Haroenv
Copy link
Contributor Author

Haroenv commented Jul 7, 2016

I just noticed that I'm impossibly far behind on upstream, I'll delete this and try again later.

@Haroenv Haroenv closed this Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haroenv @thgh