Skip to content

fix: inplace import abort #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix: inplace import abort #1278

merged 2 commits into from
Feb 5, 2025

Conversation

caoxing9
Copy link
Contributor

No description provided.

@caoxing9 caoxing9 added the preview This issue is already ready for preview label Jan 26, 2025
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1278.sealoshzh.site

Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1278.sealoshzh.site

@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 13132259097

Details

  • 25 of 29 (86.21%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 81.615%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/calculation/batch.service.ts 15 19 78.95%
Totals Coverage Status
Change from base Build 12973868300: -0.002%
Covered Lines: 31133
Relevant Lines: 38146

💛 - Coveralls

@caoxing9 caoxing9 requested a review from tea-artist February 1, 2025 12:46
if (this.cls.get('tx.id')) {
await batchOperators();
} else {
this.prismaService.$transaction(async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing await here


// 3.update data
await wrapWithValidationErrorHandler(() => prisma.$executeRawUnsafe(updateRecordSql));
const batchOperators = async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prisma.client could not execute these sqls in a transaction

@tea-artist tea-artist self-requested a review February 1, 2025 13:14
Copy link

github-actions bot commented Feb 4, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1278.sealoshzh.site

1 similar comment
Copy link

github-actions bot commented Feb 4, 2025

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-1278.sealoshzh.site

Copy link

github-actions bot commented Feb 5, 2025

Deployment Status: ❌ Failed

@caoxing9 caoxing9 merged commit 984b5b4 into develop Feb 5, 2025
12 of 13 checks passed
@caoxing9 caoxing9 deleted the fix/import-inplace branch February 5, 2025 07:05
Copy link

github-actions bot commented Feb 5, 2025

🧹 Preview Environment Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This issue is already ready for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants