Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#759) null 방지 추가 #760

Merged
merged 14 commits into from
Sep 22, 2024
Merged

merge: (#759) null 방지 추가 #760

merged 14 commits into from
Sep 22, 2024

Conversation

4mjeo
Copy link
Member

@4mjeo 4mjeo commented Sep 21, 2024

작업 내용 설명

  • 외출 사유에 null이 들어가 NPE가 터지는걸 방지했습니다.

주요 변경 사항

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@4mjeo 4mjeo added the 👾bug 버그가 발생한 경우 label Sep 21, 2024
@4mjeo 4mjeo self-assigned this Sep 21, 2024
@4mjeo 4mjeo linked an issue Sep 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 3.16%. Comparing base (9fb2f83) to head (f477c62).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...ns/dms/domain/outing/spi/vo/OutingApplicationVO.kt 0.00% 1 Missing ⚠️
.../team/aliens/dms/thirdparty/parser/ExcelAdapter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #760   +/-   ##
=========================================
  Coverage       3.16%   3.16%           
  Complexity        85      85           
=========================================
  Files            652     652           
  Lines           9102    9102           
  Branches         212     213    +1     
=========================================
  Hits             288     288           
  Misses          8805    8805           
  Partials           9       9           
Flag Coverage Δ
3.16% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ns/dms/domain/outing/spi/vo/OutingApplicationVO.kt 0.00% <0.00%> (ø)
.../team/aliens/dms/thirdparty/parser/ExcelAdapter.kt 15.52% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb2f83...f477c62. Read the comment docs.

Copy link

sonarcloud bot commented Sep 22, 2024

@4mjeo 4mjeo merged commit 151c7fd into develop Sep 22, 2024
4 checks passed
@4mjeo 4mjeo deleted the fix/759-print-excel-bug branch September 22, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👾bug 버그가 발생한 경우
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

엑셀 출력 버그 해결
4 participants