Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#777) volunteer service 추가 #778

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

4mjeo
Copy link
Member

@4mjeo 4mjeo commented Sep 30, 2024

작업 내용 설명

  • 사용가능 기능(available features)에 봉사 기능을 추가했습니다.

주요 변경 사항

  • 풀리퀘 번호 777이라 신나네요!

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@4mjeo 4mjeo added the feat 새로운 기능을 추가 할 경우 label Sep 30, 2024
@4mjeo 4mjeo self-assigned this Sep 30, 2024
@4mjeo 4mjeo linked an issue Sep 30, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 3.14%. Comparing base (b82efef) to head (3973af0).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ersistence/school/mapper/AvailableFeatureMapper.kt 0.00% 4 Missing ⚠️
...eam/aliens/dms/domain/school/dto/SchoolResponse.kt 0.00% 2 Missing ⚠️
...aliens/dms/domain/school/model/AvailableFeature.kt 0.00% 2 Missing ⚠️
...in/school/usecase/QueryAvailableFeaturesUseCase.kt 0.00% 2 Missing ⚠️
...istence/school/entity/AvailableFeatureJpaEntity.kt 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #778      +/-   ##
============================================
- Coverage       3.15%   3.14%   -0.01%     
  Complexity        85      85              
============================================
  Files            653     653              
  Lines           9137    9144       +7     
  Branches         212     212              
============================================
  Hits             288     288              
- Misses          8840    8847       +7     
  Partials           9       9              
Files with missing lines Coverage Δ
...eam/aliens/dms/domain/school/dto/SchoolResponse.kt 0.00% <0.00%> (ø)
...aliens/dms/domain/school/model/AvailableFeature.kt 0.00% <0.00%> (ø)
...in/school/usecase/QueryAvailableFeaturesUseCase.kt 0.00% <0.00%> (ø)
...istence/school/entity/AvailableFeatureJpaEntity.kt 0.00% <0.00%> (ø)
...ersistence/school/mapper/AvailableFeatureMapper.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82efef...3973af0. Read the comment docs.

@4mjeo 4mjeo merged commit 13045c9 into develop Oct 4, 2024
4 checks passed
@4mjeo 4mjeo deleted the feat/777-add-volunteer-service branch October 4, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

사용 가능 기능에 volunteer_service 추가
2 participants