Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#783) id 필드 추가 및 name 필드 명 변경 #784

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

zios0707
Copy link
Collaborator

@zios0707 zios0707 commented Oct 8, 2024

작업 내용 설명

  • id 필드 추가
  • volunteer_name 필드 명 name 으로 변경

주요 변경 사항

결과물

image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@zios0707 zios0707 added the chore 사소한 변경 label Oct 8, 2024
@zios0707 zios0707 self-assigned this Oct 8, 2024
@zios0707 zios0707 linked an issue Oct 8, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 3.10%. Comparing base (572ae4a) to head (622887e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...domain/volunteer/dto/response/VolunteerResponse.kt 0.00% 4 Missing ⚠️
...in/volunteer/spi/vo/CurrentVolunteerApplicantVO.kt 0.00% 2 Missing ⚠️
.../repository/vo/QueryCurrentVolunteerApplicantVO.kt 0.00% 2 Missing ⚠️
...olunteer/VolunteerApplicationPersistenceAdapter.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #784      +/-   ##
============================================
- Coverage       3.11%   3.10%   -0.01%     
  Complexity        85      85              
============================================
  Files            656     656              
  Lines           9259    9264       +5     
  Branches         215     215              
============================================
  Hits             288     288              
- Misses          8962    8967       +5     
  Partials           9       9              
Files with missing lines Coverage Δ
...olunteer/VolunteerApplicationPersistenceAdapter.kt 0.00% <0.00%> (ø)
...in/volunteer/spi/vo/CurrentVolunteerApplicantVO.kt 0.00% <0.00%> (ø)
.../repository/vo/QueryCurrentVolunteerApplicantVO.kt 0.00% <0.00%> (ø)
...domain/volunteer/dto/response/VolunteerResponse.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572ae4a...622887e. Read the comment docs.

Copy link

sonarcloud bot commented Oct 8, 2024

@zios0707 zios0707 merged commit 38fced8 into develop Oct 8, 2024
4 checks passed
@zios0707 zios0707 deleted the chore/783-current-volunteer branch October 8, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 사소한 변경
Projects
None yet
Development

Successfully merging this pull request may close these issues.

봉사 현황 조회에 봉사 활동 id 추가
2 participants