Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#788) 외출 내역 조회 API 변경 #790

Merged
merged 11 commits into from
Oct 16, 2024

Conversation

ilyoil2
Copy link
Member

@ilyoil2 ilyoil2 commented Oct 13, 2024

작업 내용 설명

  • 외출 내역 조회 API 변경

주요 변경 사항

  • outingStatus 삭제 및 isApproved와 isComeback을 추가했습니다

결과물

image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@ilyoil2 ilyoil2 added the feat 새로운 기능을 추가 할 경우 label Oct 13, 2024
@ilyoil2 ilyoil2 self-assigned this Oct 13, 2024
@ilyoil2 ilyoil2 linked an issue Oct 13, 2024 that may be closed by this pull request
@ilyoil2
Copy link
Member Author

ilyoil2 commented Oct 13, 2024

외출 복귀 확인을 isComeback으로 하고 외출 허가 여부를 isApproved로 했는데 더 좋은 이름이 있으면 추천해주세요

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 4.28571% with 67 lines in your changes missing coverage. Please review.

Project coverage is 3.07%. Comparing base (7de8ed1) to head (90c29b7).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...ng/usecase/GetOutingApplicationHistoriesUseCase.kt 0.00% 26 Missing ⚠️
...ence/outing/OutingApplicationPersistenceAdapter.kt 0.00% 10 Missing ⚠️
...aliens/dms/domain/outing/spi/vo/OutingHistoryVO.kt 0.00% 5 Missing ⚠️
...tence/outing/repository/vo/QueryOutingHistoryVO.kt 0.00% 5 Missing ⚠️
...stence/outing/entity/OutingApplicationJpaEntity.kt 0.00% 4 Missing ⚠️
...rsistence/outing/mapper/OutingApplicationMapper.kt 0.00% 4 Missing ⚠️
...ns/dms/domain/outing/spi/vo/OutingApplicationVO.kt 0.00% 3 Missing ⚠️
...e/outing/repository/vo/QueryOutingApplicationVO.kt 0.00% 3 Missing ⚠️
...ns/dms/domain/outing/usecase/ApplyOutingUseCase.kt 0.00% 2 Missing ⚠️
.../dms/domain/outing/service/GetOutingServiceImpl.kt 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #790      +/-   ##
============================================
- Coverage       3.11%   3.07%   -0.04%     
+ Complexity        85      84       -1     
============================================
  Files            656     655       -1     
  Lines           9250    9258       +8     
  Branches         216     217       +1     
============================================
- Hits             288     285       -3     
- Misses          8953    8964      +11     
  Partials           9       9              
Files with missing lines Coverage Δ
...s/dms/domain/outing/dto/response/OutingResponse.kt 0.00% <ø> (ø)
...liens/dms/domain/outing/model/OutingApplication.kt 100.00% <100.00%> (ø)
...domain/outing/spi/vo/CurrentOutingApplicationVO.kt 0.00% <ø> (ø)
...g/repository/vo/QueryCurrentOutingApplicationVO.kt 0.00% <ø> (ø)
.../dms/domain/outing/service/GetOutingServiceImpl.kt 0.00% <0.00%> (ø)
...ting/usecase/ExportAllOutingApplicationsUseCase.kt 0.00% <0.00%> (ø)
.../dms/domain/outing/usecase/UnApplyOutingUseCase.kt 0.00% <0.00%> (ø)
...domain/outing/usecase/UpdateOutingStatusUseCase.kt 0.00% <0.00%> (ø)
.../team/aliens/dms/domain/outing/OutingWebAdapter.kt 0.00% <0.00%> (ø)
...ns/dms/domain/outing/usecase/ApplyOutingUseCase.kt 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de8ed1...90c29b7. Read the comment docs.

Copy link

sonarcloud bot commented Oct 16, 2024

@ilyoil2 ilyoil2 merged commit 59b98cd into develop Oct 16, 2024
3 of 4 checks passed
@ilyoil2 ilyoil2 deleted the ref/788-get-outing-history-api branch October 16, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

외출 내역 조회 API 수정
3 participants