Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve filter functionality #1224

Merged
merged 7 commits into from
Aug 26, 2023
Merged

feat: improve filter functionality #1224

merged 7 commits into from
Aug 26, 2023

Conversation

mitosagi
Copy link
Collaborator

@mitosagi mitosagi commented Apr 16, 2023 •
edited
Loading

Description

Improve usability by changing the package filtering UI from a drop-down box to a sidebar. Support filtering plugins and scripts.　Also, add a flow that encourages users to add packages.

Related Issue

Motivation and Context

How Has This Been Tested?

  • All filtering options are working properly.

Screenshots (if appropriate):

SS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mitosagi mitosagi added Feedback: enhancement New feature or request Type: improvement Improvements to program Type: new feature Suggesting new features labels Apr 16, 2023
@mitosagi mitosagi requested a review from a team April 16, 2023 02:41
hal-shu-sato
hal-shu-sato requested changes Aug 26, 2023
View reviewed changes
Copy link
Member

@hal-shu-sato hal-shu-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a very small change to request.
But, the other is good.

src/renderer/main/package.ts Outdated Show resolved Hide resolved
hal-shu-sato
hal-shu-sato previously approved these changes Aug 26, 2023
View reviewed changes
hal-shu-sato
hal-shu-sato approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@hal-shu-sato hal-shu-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that all features worked fine.

@hal-shu-sato hal-shu-sato merged commit c8588dc into team-apm:main Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hal-shu-sato hal-shu-sato hal-shu-sato approved these changes

Assignees

@hal-shu-sato hal-shu-sato

Labels
Feedback: enhancement New feature or request Type: improvement Improvements to program Type: new feature Suggesting new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate plugins and script into other tabs
2 participants
@mitosagi @hal-shu-sato