Grading/Feedback PR [DO NOT MERGE] #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

martypdx wants to merge 2 commits into team-lollipop:master from martypdx:master

martypdx commented May 14, 2018

Good looking project, ambitious tackling of state-based game and you pulled it off.

initial npm i && npm test worked after making .env 👍
CLI looked really good!
Code was very clean and consistent
Try and use destructing a bit more in routes
You can't trust user supplied things like their id and role :(
Nice tests

martypdx added 2 commits

May 13, 2018 19:59


          initial commit

1cc89e6


          grading feedback PR

1778f1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet