Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/#125 : LectureEvaluationTab 하드코딩 제거 #128

Merged
merged 2 commits into from
Feb 1, 2024
Merged

refactor/#125 : LectureEvaluationTab 하드코딩 제거 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
745f703
refactor/#125 : LectureEvaluationTab 하드코딩 제거
BEEEAM-J Jan 31, 2024
e742c61
chore/#125 : ktlint
BEEEAM-J Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions core/model/src/main/java/com/suwiki/core/model/enums/LectureEvaluationTab.kt
View file
Open in desktop

This file was deleted.

18 changes: 18 additions & 0 deletions core/ui/src/main/java/com/suwiki/core/ui/enums/LectureEvaluationTab.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.suwiki.core.ui.enums

import androidx.annotation.StringRes
import com.suwiki.core.ui.R

enum class LectureEvaluationTab(
val position: Int,
@StringRes val title: Int,
) {
LECTURE_EVALUATION(
position = 0,
title = R.string.word_lecture_evaluation,
),
EXAM_INFO(
position = 1,
title = R.string.word_exam_info,
),
}
4 changes: 2 additions & 2 deletions ...evaluation/my/src/main/java/com/suwiki/feature/lectureevaluation/my/MyEvaluationScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ import com.suwiki.core.designsystem.component.tabbar.TabTitle
import com.suwiki.core.designsystem.theme.Gray95
import com.suwiki.core.designsystem.theme.SuwikiTheme
import com.suwiki.core.designsystem.theme.White
import com.suwiki.core.model.enums.LectureEvaluationTab
import com.suwiki.core.model.lectureevaluation.exam.MyExamEvaluation
import com.suwiki.core.model.lectureevaluation.lecture.MyLectureEvaluation
import com.suwiki.core.ui.enums.LectureEvaluationTab
import com.suwiki.core.ui.extension.OnBottomReached
import com.suwiki.core.ui.extension.collectWithLifecycle
import com.suwiki.core.ui.extension.encodeToUri
Expand Down Expand Up @@ -151,7 +151,7 @@ fun MyEvaluationScreen(
LectureEvaluationTab.entries.forEach { tab ->
with(tab) {
TabTitle(
title = title,
title = stringResource(title),
position = position,
selected = pagerState.currentPage == position,
onClick = { onClickTab(position) },
Expand Down
4 changes: 2 additions & 2 deletions ...m/suwiki/feature/lectureevaluation/viewerreporter/detail/LectureEvaluationDetailScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import com.suwiki.core.designsystem.theme.Gray95
import com.suwiki.core.designsystem.theme.Primary
import com.suwiki.core.designsystem.theme.SuwikiTheme
import com.suwiki.core.designsystem.theme.White
import com.suwiki.core.model.enums.LectureEvaluationTab
import com.suwiki.core.ui.enums.LectureEvaluationTab
import com.suwiki.core.ui.extension.OnBottomReached
import com.suwiki.core.ui.extension.collectWithLifecycle
import com.suwiki.core.ui.extension.suwikiClickable
Expand Down Expand Up @@ -181,7 +181,7 @@ fun LectureEvaluationDetailScreen(
LectureEvaluationTab.entries.forEach { tab ->
with(tab) {
TabTitle(
title = title,
title = stringResource(title),
position = position,
selected = pagerState.currentPage == position,
onClick = { onClickTab(position) },
Expand Down
2 changes: 1 addition & 1 deletion ...uwiki/feature/lectureevaluation/viewerreporter/detail/LectureEvaluationDetailViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ package com.suwiki.feature.lectureevaluation.viewerreporter.detail

import androidx.lifecycle.SavedStateHandle
import androidx.lifecycle.ViewModel
import com.suwiki.core.model.enums.LectureEvaluationTab
import com.suwiki.core.model.exception.UserPointLackException
import com.suwiki.core.model.lectureevaluation.exam.MyExamEvaluation
import com.suwiki.core.model.lectureevaluation.lecture.MyLectureEvaluation
import com.suwiki.core.ui.enums.LectureEvaluationTab
import com.suwiki.core.ui.extension.encodeToUri
import com.suwiki.domain.lectureevaluation.viewerreporter.usecase.exam.BuyExamUseCase
import com.suwiki.domain.lectureevaluation.viewerreporter.usecase.exam.GetExamEvaluationListUseCase
Expand Down
Loading