Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/align filter component #49

Merged
merged 20 commits into from
Dec 14, 2023
Merged

Feature/align filter component #49

merged 20 commits into from
Dec 14, 2023

Conversation

BEEEAM-J
Copy link
Member

@BEEEAM-J BEEEAM-J commented Dec 10, 2023 •
edited
Loading

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • Align & Filter ๊ด€๋ จ Component ๊ตฌํ˜„

๐ŸŒฑ PR ํฌ์ธํŠธ

  • Figma์—๋Š” SuwikiFilterContainer์˜ ๋ณ„ ์ƒ‰์ด ๊ณ ์ •๋˜์–ด ์žˆ์ง€๋งŒ ์ฆ๊ฒจ์ฐพ๊ธฐ ๋ฒ„ํŠผ์œผ๋กœ ์ƒ๊ฐ๋˜์–ด์„œ ๋ณ„์˜ ์ƒ‰์„ ๋ณ„ ํด๋ฆญ ์—ฌ๋ถ€๋กœ ๋ณ€๊ฒฝํ•˜๋„๋ก ๊ตฌํ˜„ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • Filter Component๋“ค์ด preview๋กœ ๋ณผ ๋•Œ์™€ ์—๋ฎฌ๋ ˆ์ดํ„ฐ๋กœ ์‹คํ–‰ํ–ˆ์„ ๋•Œ ๋‹ค๋ฅด๊ฒŒ ๋‚˜ํƒ€๋‚˜๋Š” ํ˜„์ƒ์ด ์žˆ์ง€๋งŒ ์ด๋Š” ํฐํŠธ๋ฅผ ์ ์šฉํ•˜๋ฉด ํ•ด๊ฒฐ๋  ๋ฌธ์ œ๋ผ๊ณ  ํŒ๋‹จํ•˜์—ฌ ์ˆ˜์ •ํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
Align Filter Component Test
Color, typography ์ ์šฉ
์ƒ‰, ํฐํŠธ ์ ์šฉํ•œ๊ฑฐ ํ…Œ์ŠคํŠธ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@BEEEAM-J BEEEAM-J requested review from jinukeu and lsakee December 10, 2023 11:33
@BEEEAM-J BEEEAM-J self-assigned this Dec 10, 2023
jinukeu
jinukeu requested changes Dec 10, 2023
View reviewed changes
...designsystem/src/main/java/com/suwiki/core/designsystem/component/align/SuwikiAlignButton.kt Outdated
Comment on lines 26 to 30
modifier = Modifier
.size(40.dp)
.clip(RoundedCornerShape(10.dp))
.suwikiClickable(onClick = onClick)
.background(Color(0xFFFFFFFF)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shadow ๋ˆ„๋ฝ๋œ๊ฑฐ๊ฐ™์•„์š”~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ๋ž‘ ๊ฐ™์€ ์ปดํฌ์ €๋ธ”์ด SuwikiSearchBarWithFilter์— ์žˆ๋Š”๋ฐ ์—ฌ๊ธฐ ๋ณด๋‹ˆ๊นŒ shadow ์†์„ฑ์ด .shadow(elevation = 10.dp) // TODO Custom Shadow๋กœ ๋ณ€๊ฒฝํ•ด์•ผํ•จ ์ด๋ ‡๊ฒŒ ์ •์˜๋˜์–ด ์žˆ๋Š”๋ฐ ์ผ๋‹จ ์ด์ฒ˜๋Ÿผ ์ ์šฉํ•˜๋ฉด ๋ ๊นŒ์š”?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ ์ฃ„์†กํ•ด์š”!! ์ด๊ฑฐ ์ง€๊ธˆ๋ดค๋„ค์š”.
์œผ์Œ ๋„ต ์ผ๋‹จ ๊ทธ๋ ‡๊ฒŒ ์ ์šฉํ•ด์ฃผ์„ธ์š”! ์ œ๊ฐ€ ๋‚˜์ค‘์— ๋ณ€๊ฒฝํ•ด๋†“์„๊ฒŒ์š”~!

...ignsystem/src/main/java/com/suwiki/core/designsystem/component/align/SuwikiAlignContainer.kt Outdated Show resolved Hide resolved
...ignsystem/src/main/java/com/suwiki/core/designsystem/component/align/SuwikiAlignContainer.kt Outdated Show resolved Hide resolved
...designsystem/src/main/java/com/suwiki/core/designsystem/component/align/SuwikiAlignButton.kt Outdated
Comment on lines 31 to 38
) {
Icon(
painter = painterResource(id = R.drawable.ic_filter),
contentDescription = "",
modifier = Modifier.align(Alignment.Center),
tint = Color(0xFF6A6A6A),
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตณ์ด Box๋กœ ์•ˆ๊ฐ์‹ธ๋„ ๋˜์ง€ ์•Š๋‚˜์š”?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €๋„ ์š”๋ถ€๋ถ„ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค ํ•„ํ„ฐ ์•„์ด์ฝ˜์˜ ์ถ”๊ฐ€์ ์œผ๋กœ ๋“ค์–ด๊ฐˆ ๋ ˆ์ด์•„์›ƒ ์žˆ๋‚˜์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฒ„ํŠผ๊ณผ ๋‚ด๋ถ€์˜ ์•„์ด์ฝ˜ ์‚ฌ์ด์˜ ๊ฐ„๊ฒฉ์„ ํ‘œํ˜„ํ•˜๋ ค๊ณ  ๋ฐ•์Šค๋กœ ๊ฐ์ŒŒ๋Š”๋ฐ ํ˜น์‹œ ๋” ์ข‹์€ ๋ฐฉ๋ฒ•์ด ์žˆ๋‚˜์š”???

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„์ด์ฝ˜์— ํŒจ๋”ฉ์„ ์ถ”๊ฐ€ํ•ด๋ณด๋Š”๊ฑด ์–ด๋–ค๊ฐ€์š”?
์‚ฌ์ด์ฆˆ๋„ ์กฐ์ ˆํ•˜๊ตฌ์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค์˜ท modifier ์ด๋ ‡๊ฒŒ ์„ค์ •ํ•˜๋‹ˆ๊นŒ ๋˜๋„ค์š”~
ํ•˜๋‚˜ ๋ฐฐ์› ์Šด๋‹ค!

modifier = Modifier
      .size(40.dp)
      .clip(RoundedCornerShape(10.dp))
      .suwikiClickable(onClick = onClick)
      .background(Color(0xFFFFFFFF))
      .padding(8.dp)

...ignsystem/src/main/java/com/suwiki/core/designsystem/component/align/SuwikiAlignContainer.kt Outdated Show resolved Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/filter/SuwikiFilterButton.kt Outdated Show resolved Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/filter/SuwikiFilterButton.kt Outdated Show resolved Hide resolved
...nsystem/src/main/java/com/suwiki/core/designsystem/component/filter/SuwikiFilterContainer.kt Outdated Show resolved Hide resolved
...nsystem/src/main/java/com/suwiki/core/designsystem/component/filter/SuwikiFilterContainer.kt Outdated Show resolved Hide resolved
...nsystem/src/main/java/com/suwiki/core/designsystem/component/filter/SuwikiFilterContainer.kt Outdated Show resolved Hide resolved
lsakee
lsakee requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ • ์‚ฌ์ด์ฆˆ๋ณด๋‹จ ์œ ๋™์ ์œผ๋กœ ์งœ๋Š”๊ฒŒ ์ข‹์„ ๊ฑฐ๊ฐ™์Šต๋‹ˆ๋‹ค! ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

...designsystem/src/main/java/com/suwiki/core/designsystem/component/align/SuwikiAlignButton.kt Outdated
Comment on lines 31 to 38
) {
Icon(
painter = painterResource(id = R.drawable.ic_filter),
contentDescription = "",
modifier = Modifier.align(Alignment.Center),
tint = Color(0xFF6A6A6A),
)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €๋„ ์š”๋ถ€๋ถ„ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค ํ•„ํ„ฐ ์•„์ด์ฝ˜์˜ ์ถ”๊ฐ€์ ์œผ๋กœ ๋“ค์–ด๊ฐˆ ๋ ˆ์ด์•„์›ƒ ์žˆ๋‚˜์š”?

@jinukeu jinukeu self-requested a review December 13, 2023 03:58
@BEEEAM-J
Copy link
Member Author

ํ”ผ๋“œ๋ฐฑ ์ „๋ถ€ ๋ฐ˜์˜ํ•˜๊ณ  color, typography๊นŒ์ง€ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค~

jinukeu
jinukeu requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@jinukeu jinukeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text์™€ ๊ฐ™์€ ์ปดํฌ๋„ŒํŠธ์— wrapHeightSize, fillMaxSize๋กœ ๊ฐ์‹ธ์ง€ ์•Š์•„๋„ ๋˜๋Š”๋ฐ ๊ฐ์‹ผ ๋ถ€๋ถ„์ด ์ข€ ๋ณด์ด๋Š”๊ฑฐ๊ฐ™์•„์š”! Text ๋ง๊ณ ๋„ ํ•œ๋ฒˆ ์ญ‰ ๊ฒ€ํ†  ๋ถ€ํƒ๋“œ๋ฆด๊ฒŒ์š”!

...signsystem/src/main/java/com/suwiki/core/designsystem/component/filter/SuwikiFilterButton.kt Outdated Show resolved Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/filter/SuwikiFilterButton.kt Outdated Show resolved Hide resolved
...nsystem/src/main/java/com/suwiki/core/designsystem/component/filter/SuwikiFilterContainer.kt Outdated Show resolved Hide resolved
...ignsystem/src/main/java/com/suwiki/core/designsystem/component/align/SuwikiAlignContainer.kt Outdated Show resolved Hide resolved
@BEEEAM-J
Copy link
Member Author

๊ฒ€ํ† ํ•˜๊ณ  ์ˆ˜์ •๊นŒ์ง€ ํ–ˆ์Šต๋‹ˆ๋‹ค!

jinukeu
jinukeu approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@jinukeu jinukeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค ๐Ÿ‘ ๐Ÿ‘

lsakee
lsakee approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๊ณ ์ƒํ•ฌ์…จ์Šต๋‹ˆ๋‹ค!

@BEEEAM-J BEEEAM-J merged commit 1e74d6d into develop Dec 14, 2023
1 check passed
@jinukeu jinukeu deleted the feature/align-filter-component branch December 20, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsakee lsakee lsakee approved these changes

@jinukeu jinukeu jinukeu approved these changes

Assignees

@BEEEAM-J BEEEAM-J

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Align & Filter Component
3 participants
@BEEEAM-J @jinukeu @lsakee