Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#36 theme #50

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Feature/#36 theme #50

merged 5 commits into from
Dec 11, 2023

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Dec 11, 2023

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • Color, Typography, Theme ์ถ”๊ฐ€

๐ŸŒฑ PR ํฌ์ธํŠธ
Figam - DesignSystem์˜ colorScheme์ด ์•„์ง ๋œ ์ ์šฉ๋˜์–ด ๋ฐ˜์˜ํ•˜์ง€ ๋ชปํ–ˆ์Šต๋‹ˆ๋‹ค.

์‚ฌ์šฉ ์˜ˆ์‹œ

// ์ ์šฉ ์ „
Color(0xFFFD873B)

// ์ ์šฉ ํ›„
Orange100

// ์ ์šฉ ์ „
Text(
    fontSize = 12.sp
)

// ์ ์šฉ ํ›„
Text(
    style = SuwikiTheme.typography.header1,
)

SuwikiTheme์œผ๋กœ ๊ฐ์‹ธ์•ผ Preview์— ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ ์šฉ๋ฉ๋‹ˆ๋‹ค.

@Preview(showBackground = true, backgroundColor = 0xFFFFFF)
@Composable
fun SuwikiContainedChipPreview() {
  SuwikiTheme {
    var isChecked by remember { mutableStateOf(false) }

    SuwikiContainedChip(
      isChecked = isChecked,
      onClick = { isChecked = !isChecked },
      type = SuwikiChipType.GREEN,
      text = "label",
    )
  }
}

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@jinukeu jinukeu requested review from lsakee and BEEEAM-J December 11, 2023 06:07
@jinukeu jinukeu self-assigned this Dec 11, 2023
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šด๋‹ค!

@jinukeu jinukeu merged commit 59230dc into develop Dec 11, 2023
1 check passed
@jinukeu jinukeu deleted the feature/#36-theme branch December 13, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Theme Setting
3 participants