Skip to content

Feature/#82 find id password#83

Merged
jinukeu merged 5 commits intodevelopfrom
feature/#82-find-id-password
Jan 8, 2024
Merged

Feature/#82 find id password#83
jinukeu merged 5 commits intodevelopfrom
feature/#82-find-id-password

Conversation

@jinukeu
Copy link
Copy Markdown
Member

@jinukeu jinukeu commented Jan 8, 2024

📌 PR 요약

🌱 작업한 내용

  • 아이디 찾기, 비번 찾기 구현했습니다~!

🌱 PR 포인트

📸 스크린샷

아이디 찾기 비번 찾기
아이디 찾기 비번찾기

📮 관련 이슈

@jinukeu jinukeu added the feature label Jan 8, 2024
@jinukeu jinukeu requested a review from BEEEAM-J January 8, 2024 08:00
@jinukeu jinukeu self-assigned this Jan 8, 2024
Copy link
Copy Markdown
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~!!
궁금한 점 있어서 질문 남깁니다!

SuwikiContainedLargeButton(
modifier = Modifier.imePadding(),
text = stringResource(R.string.word_find_password),
onClick = onClickFindPasswordButton,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 동작으로 비밀번호 찾는 api 호출하는 거 까지는 이해가 됐는데 toast 메세지를 띄우는 동작은 어디에 정의 되어 있는 건가요??

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findPasswordUseCase(loginId = state.id, email = state.email)
      .onSuccess {
        reduce { state.copy(showFindPasswordSuccessDialog = true) }
      }
      .onFailure {
        postSideEffect(FindPasswordSideEffect.HandleException(it))
      }

여기 보시면 실패한 경우에 HandleException SideEffect를 발생시킵니다!
HandleException은 MainScreen까지 전달되구용 MainScreen에서 토스트를 띄웁니다!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하! 그래서 스크린에서 따로 토스트를 넣지 않았던거군요
참고하겠습니다 :)

@jinukeu jinukeu merged commit e257aef into develop Jan 8, 2024
@jinukeu jinukeu deleted the feature/#82-find-id-password branch January 9, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] 아이디, 비밀번호 찾기

2 participants