New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ENGDESK-26634-hotfix): the `params.customHeaders` was not destructuring correctly the values #339

Merged

DeividVeloso merged 1 commit into main from ENGDESK-26634-hotfix

Nov 23, 2023

Contributor

DeividVeloso commented Nov 23, 2023

the params.customHeaders was not destructuring correctly the values

📝 To Do

All linters pass
All tests pass
Change documentation based on my changes

✋ Manual testing

navigate to packages/js
run yarn build
run yarn link
go to a webrtc project and run the yarn link @telnyx/webrtc
make a call and receive a call
it should work normally.

🦊 Browser testing

Desktop

Edge (latest)
Chrome
Firefox
Safari

📸 Screenshots

Description	Screenshot
Desktop
usage.gif


          fix: the params.customHeaders was not being destructuring correctly t…

d323378

…he values

DeividVeloso requested review from a team, ericaprieto, lmao12, jonathan-telnyx and priscillasantana

November 23, 2023 12:31

DeividVeloso merged commit b7e1c2a into main

2 checks passed

DeividVeloso deleted the ENGDESK-26634-hotfix branch

November 23, 2023 12:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericaprieto Awaiting requested review from ericaprieto ericaprieto is a code owner automatically assigned from team-telnyx/frontend

lmao12 Awaiting requested review from lmao12 lmao12 is a code owner automatically assigned from team-telnyx/frontend

jonathan-telnyx Awaiting requested review from jonathan-telnyx jonathan-telnyx is a code owner automatically assigned from team-telnyx/frontend

priscillasantana Awaiting requested review from priscillasantana priscillasantana is a code owner automatically assigned from team-telnyx/frontend

Labels

None yet