Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multithreading odometry #51

Open
wants to merge 2 commits into
base: phoenix6
Choose a base branch
from

Conversation

MatthewChoulas
Copy link
Contributor

No description provided.

Copy link
Member

@sswadkar sswadkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, few changes to make before we merge in

@@ -31,6 +31,8 @@ object DrivetrainConstants {
const val FOC_ENABLED = false
const val MINIMIZE_SKEW = false

const val OMOMETRY_UPDATE_FREQUENCY = 250.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add units for frequency? t = 1/f so it should be as something like

inline val Double.hertz: Time
  get() = Time(1/this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants