Merge pull request #332 from teamleadercrm/cache-proxy-values

Cache the values that are created by the proxy
teamleadercrm · Aug 30, 2022 · 8f69002 · 8f69002
2 parents 24f20d4 + 04d93c5
commit 8f69002
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 ### Changed
 
+- Cache the values that are created by the proxy. So if you call an endpoint 2 times, it will call the same function 2 times. This makes testing easier. ([@lowiebenoot](https://github.com/lowiebenoot) in [#332](https://github.com/teamleadercrm/sdk-js/pull/332))
+
 ### Deprecated
 
 ### Removed

diff --git a/src/__tests__/main.test.ts b/src/__tests__/main.test.ts
@@ -41,4 +41,16 @@ describe('fetch response handling', () => {
     const data = await api.contacts.info({ userId: '84989' }, { plugins: { response: [normalize] } });
     expect(data).toEqual({ contacts: { 84845512: { id: '84845512', lastName: 'doe', name: 'john' } } });
   });
+
+  it('using the same endpoint twice actually uses the same function', async () => {
+    const getAccessToken = () => 'thisisatoken';
+
+    const api = API({
+      getAccessToken,
+    });
+
+    expect(api.contacts.info).toEqual(api.contacts.info);
+    expect(api.companies.info).toEqual(api.companies.info);
+    expect(api.companies.info).not.toEqual(api.contacts.info);
+  });
 });
diff --git a/src/main.ts b/src/main.ts
@@ -12,23 +12,38 @@ type ActionEndpoint = <T = any>(
 ) => Promise<T>;
 
 const API = (globalConfiguration: GlobalConfiguration) => {
+  const cachedActionEndpoints: Record<string, Record<string, ActionEndpoint>> = {};
+
   return new Proxy<Record<string, Record<string, ActionEndpoint>>>(
     {},
     {
-      get(_target, domainName) {
+      get(_target, domainNameKey) {
         return new Proxy(
           {},
           {
-            get(_target, actionName) {
+            get(_target, actionNameKey) {
+              const domainName = String(domainNameKey);
+              const actionName = String(actionNameKey);
+
+              if (typeof cachedActionEndpoints[domainName] === 'undefined') {
+                cachedActionEndpoints[domainName] = {};
+              }
+
+              if (typeof cachedActionEndpoints[domainName][actionName] !== 'undefined') {
+                return cachedActionEndpoints[domainName][actionName];
+              }
+
               const actionEndpoint: ActionEndpoint = async (parameters = {}, localConfiguration = {}) => {
                 const configuration = mergeConfigurations({ globalConfiguration, localConfiguration });
                 return request({
-                  domainName: String(domainName),
-                  actionName: String(actionName),
+                  domainName,
+                  actionName,
                   parameters,
                   configuration,
                 });
               };
+
+              cachedActionEndpoints[domainName][actionName] = actionEndpoint;
               return actionEndpoint;
             },
           },