This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Change element of select remove button #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorgan3
requested review from
a team,
jelledc,
KristofColpaert,
driesd,
eniskraasniqi1 and
JorenSaeyTL
and removed request for
a team
eniskraasniqi1
approved these changes
Dec 5, 2023
qubis741
approved these changes
Dec 6, 2023
|
Manual checked 🦅 ✅
|
jelledc
approved these changes
Dec 8, 2023
farazatarodi
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rendering a select in a label element causes the first remove button to get triggered when clicking on said label.
As a solution we'll make the remove button just a div (equivalent with what it was before)