New config property "converterSuffix" #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What exactly is the problem? What breaks on “old” converter declarations? How do they look? |
jdreesen
reviewed
May 13, 2024
| @@ -28,6 +28,10 @@ private function addConverterSection(ArrayNodeDefinition $rootNode): void | |||
| { | |||
| $rootNode | |||
| ->children() | |||
| ->scalarNode('converterSuffix') | |||
| ->info('consolidated suffix for all converters') | |||
| ->defaultValue('') | |||
There was a problem hiding this comment.
This is a breaking change. The default value should be the current one.
Suggested change
| ->defaultValue('') | |
| ->defaultValue('Converter') |
jdreesen
reviewed
May 13, 2024
| @@ -28,6 +28,10 @@ private function addConverterSection(ArrayNodeDefinition $rootNode): void | |||
| { | |||
| $rootNode | |||
| ->children() | |||
| ->scalarNode('converterSuffix') | |||
| ->info('consolidated suffix for all converters') | |||
There was a problem hiding this comment.
This message is misleading. It only configures the suffix of the autowiring alias for converter arguments.
jdreesen
reviewed
May 13, 2024
| @@ -28,6 +28,10 @@ private function addConverterSection(ArrayNodeDefinition $rootNode): void | |||
| { | |||
| $rootNode | |||
| ->children() | |||
| ->scalarNode('converterSuffix') | |||
There was a problem hiding this comment.
Config parameters should be in "snake_case":
Suggested change
| ->scalarNode('converterSuffix') | |
| ->scalarNode('converter_suffix') |
Maybe we should even rename this to be more specific, like argument_autowiring_alias_suffix.
jdreesen
reviewed
May 13, 2024
| @@ -40,7 +40,7 @@ public function loadInternal(array $mergedConfig, ContainerBuilder $container): | |||
| /** | |||
| * @param array<string, mixed> $config | |||
| */ | |||
| private function registerConverterConfiguration(string $id, array $config, ContainerBuilder $container): void | |||
| private function registerConverterConfiguration(string $id, array $config, ContainerBuilder $container, ?string $converterSuffix): void | |||
There was a problem hiding this comment.
I guess this is not nullable when there's a default value defined in the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property will be introduced to enable backwards compatibilty to "older" converter declarations.