Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Workflows #80

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Activate Workflows #80

wants to merge 15 commits into from

Conversation

mike4git
Copy link
Collaborator

  • Add deptrac to qa workflow

Add deptrac to qa workflow
@mike4git mike4git linked an issue Aug 10, 2024 that may be closed by this pull request
5 tasks
add test coverage first
- add badge for coverage by codecov
change used coverage file
try coberture instead of codecov
remove badge generation and upload because of technical problems and restrictions
remove gitlab and add github specific things
remove gitlab and add github specific things
remove duplicated action
@mike4git mike4git requested a review from jdreesen August 19, 2024 09:42
@mike4git
Copy link
Collaborator Author

@jdreesen
I hope you like my approach to extract the code coverage by script and fail if it is below 80%. ;-)

@mike4git
Copy link
Collaborator Author

@jdreesen I hope you like my approach to extract the code coverage by script and fail if it is below 80%. ;-)

I didn't find a cheap way to create a badge but with that script - may be - it could be done.

@mike4git mike4git force-pushed the 13-activate-workflow branch 3 times, most recently from 1abf946 to e2f87ad Compare August 20, 2024 15:22
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to bring up the code coverage to 100% by implementing this test.
At the end coverage has increased but not calculatable because I can not model the case which throws a ReflectionException in create method because all the checks have been done in the constructor of the GenericTargetFactory.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we skip the try..catch...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we could remove it, I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activate Workflow
2 participants