-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate Workflows #80
base: main
Are you sure you want to change the base?
Conversation
mike4git
commented
Aug 10, 2024
- Add deptrac to qa workflow
Add deptrac to qa workflow
add test coverage first
- add badge for coverage by codecov
change used coverage file
try coberture instead of codecov
remove badge generation and upload because of technical problems and restrictions
remove gitlab and add github specific things
remove gitlab and add github specific things
remove duplicated action
add coverage check
3c57c17
to
035291a
Compare
@jdreesen |
I didn't find a cheap way to create a badge but with that script - may be - it could be done. |
1abf946
to
e2f87ad
Compare
e2f87ad
to
f01c8fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to bring up the code coverage to 100% by implementing this test.
At the end coverage has increased but not calculatable because I can not model the case which throws a ReflectionException
in create
method because all the checks have been done in the constructor of the GenericTargetFactory
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we skip the try..catch...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we could remove it, I suppose.
a203a04
to
a06a68e
Compare