Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
A call to
$entry->parentreturns an AugmentedCollection in Statamic v6. $entry->collection() instead of $entry->collection (which is a protected property). I think it should always have been a method call - even in Statamic v5.Creators Checklist
Thanks for your Contribution 🎉
Before you request a review, please check the following:
Reviewers Checklist
This list should help you to review your pull request:
After the PR is merged:
Note
Fix property access to use method calls in
BreadcrumbServiceCorrects incorrect direct property access in BreadcrumbService.php by replacing it with proper method calls.
$entry->collection->mount()becomes$entry->collection()->mount(), and$entry->parentbecomes$entry->parent()in the parent traversal loop.Macroscope summarized 42aefe3.