Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory: Implement auto-discovery of conf.py #8

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Apr 6, 2024

About

From the Linksmith RFC:

  • sphobjinv doesn't know how to introspect conf.py:intersphinx_mapping,
    to go from project name to docset URL.

/cc @bskinn, @chrisjsewell

This means traversal of intersphinx inventories in
`intersphinx_mapping`.
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.57%. Comparing base (c520b65) to head (92a7cc9).

Files Patch % Lines
linksmith/sphinx/core.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   99.77%   99.57%   -0.20%     
==========================================
  Files          11       11              
  Lines         440      475      +35     
==========================================
+ Hits          439      473      +34     
- Misses          1        2       +1     
Flag Coverage Δ
unittests 99.57% <97.91%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl merged commit 4622260 into main Apr 6, 2024
3 of 5 checks passed
@amotl amotl deleted the autodiscover-conf-py branch April 6, 2024 14:40
@amotl
Copy link
Contributor Author

amotl commented Apr 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant