-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[정종윤] 기능구현 챌린지 #5
Open
BellYun
wants to merge
23
commits into
techeer-sv:main
Choose a base branch
from
BellYun:Bellyun
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmswn1004
reviewed
May 18, 2024
Comment on lines
+20
to
+29
export const Header = () =>{ | ||
return( | ||
<Container> | ||
<HeaderMainBox> | ||
<div>한국임상정보</div> | ||
<div>즐겨찾기</div> | ||
</HeaderMainBox> | ||
</Container> | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요, 종윤님!
Header 컴포넌트로 분리해서 잘 작성해 주셨네요.
다만, 시맨틱 태그를 사용하면 더 좋을 것 같다는 생각이 듭니다. 예를 들어, header 컴포넌트의 최상위 요소는 <header>
태그를 사용하고, 텍스트 부분은 <p>
태그를 사용하면 시맨틱 웹 접근성 측면에서 더욱 적합할 것 같습니다.😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
필수 구현 사항
https://clinicaltrialskorea.com/studies/{검색어ID}
링크로 이동console.info("calling api")
출력을 통해 콘솔창에서 API 호출 횟수 확인이 가능하도록 설정추가 구현 사항
선택 구현 사항
과제를 수행하면서 진행하셨던 고민
구현하고자 했던 설계의 방향성