Skip to content

🐛 protect encoded dots in keys during decoding when decodeDotInKeys is false #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
techouse wants to merge 3 commits into from
Closed

🐛 protect encoded dots in keys during decoding when decodeDotInKeys is false #36

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bb15d3
:bug: protect encoded dots in keys during decoding when decodeDotInKe…
techouse Aug 20, 2025
f674ad7
:bug: handle lowercase '%2e' when decoding dots in keys and adjust do…
techouse Aug 20, 2025
e2b734d
:bug: always protect encoded dots in keys from dot-splitting regardle…
techouse Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/src/extensions/decode.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,22 @@ extension _$Decode on QS {
dynamic val;
// Bare key without '=', interpret as null vs empty-string per strictNullHandling.
if (pos == -1) {
key = options.decoder(part, charset: charset);
// Protect %2E/%2e in keys so dot-splitting never sees them as literal dots.
String keyInput = part;
if (options.allowDots && keyInput.contains('%2')) {
keyInput =
keyInput.replaceAll('%2E', '%252E').replaceAll('%2e', '%252e');
}
key = options.decoder(keyInput, charset: charset);
val = options.strictNullHandling ? null : '';
} else {
key = options.decoder(part.slice(0, pos), charset: charset);
// Protect %2E/%2e in the key slice only; values decode normally.
String keyInput = part.slice(0, pos);
if (options.allowDots && keyInput.contains('%2')) {
keyInput =
keyInput.replaceAll('%2E', '%252E').replaceAll('%2e', '%252e');
}
key = options.decoder(keyInput, charset: charset);
// Decode the substring *after* '=', applying list parsing and the configured decoder.
val = Utils.apply<dynamic>(
_parseListValue(
Expand Down Expand Up @@ -257,7 +269,7 @@ extension _$Decode on QS {
? root.slice(1, root.length - 1)
: root;
final String decodedRoot = options.decodeDotInKeys
? cleanRoot.replaceAll('%2E', '.')
? cleanRoot.replaceAll('%2E', '.').replaceAll('%2e', '.')
: cleanRoot;
final int? index = int.tryParse(decodedRoot);
if (!options.parseLists && decodedRoot == '') {
Expand Down