-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering based on the node name #219
Conversation
Summary from the hacking session: Use no key for search by fmf node name. Example:
So we don't have to invent/decide any name ;-) |
/packit test |
@psss Is the "/tests/core & tag:quick" possible with current PR? It doesn't seem so. |
This actually brings some issues. See, right now fmf filter is unable parse regular expressions that are quite common and that I assume people will likely be using (there is already a misplaced issue in tmt project for this. This problem is solvable[*] under the assumption that keys are always used. But once this PR is merged this assumption is gone. [*] Using a positive lookahead assertion as follows:
Once you have | in a regexp the only way to distinguish it from proper disjunction is to to check that some key follows it. If not then it must be a part of value of the last key. Same approach can be applied to identifying a proper conjunction. With that you can already use pretty powerful regular expressions as values (you still need to avoid using both | and : in you regexp, but probability of that is fairly low IMO). Allowing not to have a key will break this logic. |
With escaping it is clear whether |
Add support for filtering based on the node name by allowing plain literals without the `key: name` format.
Implemented and documented. @lukaszachy, please review. |
Add support for filtering based on the node name by allowing plain literals without the
key: name
format.