Allow multiplication in duration input value

[lukaszachy]

To make it easier for adjust the multiplication happens last: No need to pay attention how adjust creates the value.

Only late I realized the input value for multiplication should accept float, so I will modify that later.
For now: does this approach will be accepted? It is preparation for #1843 so "adjust" doesn't need special handling of duration key.

Pull Request Checklist

• implement the feature
• write the documentation
• extend the test coverage
• modify the json schema
• mention the version
• include a release note

[happz]

@lukaszachy do you plan to mention the version and/or include a release note?

[lukaszachy]

@lukaszachy do you plan to mention the version and/or include a release note?

I wasn't but it is a very good point.

[happz]

@lukaszachy do you plan to mention the version and/or include a release note?

I wasn't but it is a very good point.

1. those were the last two unchecked boxes on the PR checklist, and 2. this might be a good feature to point out in release notes, so I asked.

[lukaszachy]

ah, seems schema has the regexp as well, I need to change it.

[LecrisUT]

Sorry for commenting late on this closed PR, but I think pint would be a more robust approach:

>>> import pint
>>> pint.Quantity("30 * 4 min")
<Quantity(120, 'minute')>

Some care needs to be made with regards to translating 30m -> 30min, but that can be done by configuring specific pint.UnitRegistry.context and overwriting the default values for meter and such.

[happz]

Sorry for commenting late on this closed PR, but I think pint would be a more robust approach:

>>> import pint
>>> pint.Quantity("30 * 4 min")
<Quantity(120, 'minute')>

Some care needs to be made with regards to translating 30m -> 30min, but that can be done by configuring specific pint.UnitRegistry.context and overwriting the default values for meter and such.

That's right, I didn't think about using Pint for this task. I'm not sure if it would handle the ordering of operations @lukaszachy implemented though, it does not follow the mathematical ordering of multiplication and addition.

[LecrisUT]

Indeed, but the current one is also a bit hard to follow. It can look good with

    adjust:
        duration+: 1h

but the mathematical alternative is not bad either though:

    adjust:
        duration+: + 1h

I was hoping that pint would fail if the syntax is broken, but alas it does not:

>>> pint.Quantity("1h 40min")
<Quantity(40, 'hour * minute')>
>>> pint.Quantity("* 40min 1h")
Traceback (most recent call last):

At least the first issue is straightforward to verify by adding a check for dimensionality

>>> pint.Quantity("1h 40min").dimensionality["[time]"]
2