Add _translate_constraint_by_config function

[skycastlelily]

Pull Request Checklist

• implement the feature
• write the documentation
• extend the test coverage
• update the specification
• adjust plugin docstring
• modify the json schema
• mention the version
• include a release note

[skycastlelily]

This MR looks at config file and tries to find a "translation" that would match the constraint, operator, value, and if found, it'd take it from configuration,we will need this to translate some complex or containing-internal-information constrains :)

[skycastlelily]

yeah,it will be used if any _transform_*_*_ function calls _translate_constraint_by_config,should I move this function to a new merge request?^^

…

On Mon, Jun 3, 2024 at 5:01 PM Miloš Prchlík ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tmt/steps/provision/mrack.py <#2967 (comment)>: > @@ -197,6 +202,34 @@ class MrackHWNotGroup(MrackHWGroup): name: str = 'not' +def _get_custom_config() -> dict[str, Any]: This function does not seem to be called from anywhere. — Reply to this email directly, view it on GitHub <#2967 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFR23EQLS4CPESTI3BWEEDZFQWFPAVCNFSM6AAAAABIOH3ASGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJTGI2DANZYGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[skycastlelily]

Updated^^

[happz]

• I'd recommend returning an empty list, it's as false-ish as None
• is it necessary to capture there exceptions, and then either reraise, or silence it? MetadataError should be heard as loudly as SpecificationError.

I think this could be simplified (plus "custom config" can mean anything, we're speaking about "translations" of constraints directly to Beaker XML):

def _get_constraint_translations() -> list[Translate]:
    config = tmt.config.Config()

    return config.hardware.translations if config.hardware else []

[skycastlelily]

is it necessary to capture there exceptions, and then either reraise, or silence it? MetadataError should be heard as loudly as SpecificationError

We don't want to raise an error if there is no config tree,right ? so ,they should be handled differently.WDYT? :)

[happz]

Aha, I forgot it's still raising MetadataError - it will not if my https://github.com/teemtee/tmt/pull/3519/files#diff-c4acf376ac31d8918aa707c285892dd693fe71005eb4412bbfa4eb1273511f71R94 gets merged.

[skycastlelily]

Thanks for your super quick response,and pretty valuable suggestions, updated accordingly^^

[happz]

Adding blocked, to get #3519 merged first as it simplifies some pieces of configuration handling.