Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --build-disk-image-only option to bootc plugin #3567

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Add --build-disk-image-only option to bootc plugin #3567

merged 1 commit into from
Mar 20, 2025

Conversation

qcheng-redhat
Copy link
Contributor

@qcheng-redhat qcheng-redhat commented Mar 4, 2025 •
edited
Loading

Add --build-disk-image-only option to bootc plugin

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@qcheng-redhat qcheng-redhat force-pushed the build_disk_image_only branch from 2ceeaa2 to 84216a5 Compare March 4, 2025 03:29
@psss psss added the priority | must high priority, must be included in the next release label Mar 13, 2025
@psss psss added this to the 1.45 milestone Mar 13, 2025
@psss psss added the size | day Takes up to a day to implement, test & review label Mar 13, 2025
@qcheng-redhat qcheng-redhat force-pushed the build_disk_image_only branch from 84216a5 to 5532009 Compare March 14, 2025 06:40
happz
happz reviewed Mar 17, 2025
View reviewed changes
happz
happz reviewed Mar 17, 2025
View reviewed changes
happz
happz reviewed Mar 17, 2025
View reviewed changes
@thrix
Copy link
Collaborator

thrix commented Mar 18, 2025

@qcheng-redhat howdy, this is a must have issue for the release, can you please take a look at the review comments? ty

@qcheng-redhat qcheng-redhat force-pushed the build_disk_image_only branch from 5532009 to 764ed07 Compare March 18, 2025 10:03
@qcheng-redhat
Copy link
Contributor Author

@qcheng-redhat howdy, this is a must have issue for the release, can you please take a look at the review comments? ty

Thank you for the reminder. Updated.

@happz happz added ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. labels Mar 19, 2025
@qcheng-redhat @happz
Add --build-disk-image-only option to bootc plugin
48d70dc 
Signed-off-by: qcheng-redhat <qcheng@redhat.com>
@happz happz force-pushed the build_disk_image_only branch from 764ed07 to 48d70dc Compare March 20, 2025 07:45
@happz
Copy link
Collaborator

happz commented Mar 20, 2025

/packit build

@happz happz enabled auto-merge (squash) March 20, 2025 07:52
@happz happz merged commit fe46a22 into teemtee:main Mar 20, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy left review comments

@happz happz happz approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution priority | must high priority, must be included in the next release size | day Takes up to a day to implement, test & review status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.
6 participants
@qcheng-redhat @thrix @happz @lukaszachy @therazix @psss