Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for v0.0.74 Artemis API #3607

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Add support for v0.0.74 Artemis API #3607

merged 2 commits into from
Mar 18, 2025
+2 −0

Conversation

happz
Copy link
Collaborator

@happz happz commented Mar 18, 2025

Pull Request Checklist

  • implement the feature

@happz happz added plugin | artemis Related to Artemis provision plugin code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Mar 18, 2025
@happz happz added this to the 1.45 milestone Mar 18, 2025
@thrix thrix requested review from thrix, therazix and psss March 18, 2025 12:50
thrix
thrix approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

therazix
therazix approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@therazix therazix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a redundant hashtag in the comment. LGTM otherwise.

@happz @therazix
sqush: Update tmt/steps/provision/artemis.py
ff7b772 
Co-authored-by: Filip Vágner <fvagner@redhat.com>
@happz happz merged commit 0c471ad into main Mar 18, 2025
13 of 22 checks passed
@happz happz deleted the artemis-support-v0.0.74 branch March 18, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss

Assignees
No one assigned
Labels
code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. plugin | artemis Related to Artemis provision plugin
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @thrix @therazix