Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fmf_id to pending results #3609

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Add fmf_id to pending results #3609

merged 1 commit into from
Mar 20, 2025
+1 −0

Conversation

therazix
Copy link
Collaborator

Pull Request Checklist

  • implement the feature

@therazix therazix added step | execute Stuff related to the execute step status | blocked The merging of PR is blocked on some other issue code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Mar 18, 2025
@therazix therazix added this to the 1.45 milestone Mar 18, 2025
@therazix
Copy link
Collaborator Author

This needs #3608 to be merged first.

thrix
thrix approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz force-pushed the fvagner-prune-path branch from 6ce737b to 92eb89a Compare March 19, 2025 07:58
Base automatically changed from fvagner-prune-path to main March 19, 2025 11:08
@therazix therazix added ci | full test Pull request is ready for the full test execution and removed status | blocked The merging of PR is blocked on some other issue labels Mar 19, 2025
@therazix therazix force-pushed the fvagner-pending-result-fmf-id branch from 5131f91 to 88002c4 Compare March 19, 2025 11:12
@happz happz force-pushed the fvagner-pending-result-fmf-id branch from 88002c4 to 2de75b8 Compare March 20, 2025 09:58
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Mar 20, 2025
@psss psss merged commit e0ec7d3 into main Mar 20, 2025
19 of 22 checks passed
@psss psss deleted the fvagner-pending-result-fmf-id branch March 20, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@thrix thrix thrix approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | execute Stuff related to the execute step
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.
5 participants
@therazix @happz @thrix @KwisatzHaderach @psss