Skip to content

Commit

Permalink
fix(minio): omit protocol
Browse files Browse the repository at this point in the history
  • Loading branch information
aldy505 committed Oct 27, 2024
1 parent de9feb0 commit b3ea738
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions tests/s3/minio.integration.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ describe("S3 Provider - Integration", () => {
const s3Access = process.env.S3_ACCESS ?? "teknologi-umum";
const s3Secret = process.env.S3_SECRET ?? "very-strong-password";
const bucketName = "blob-js";
const parsedHostUrl = new URL(s3Host);
const s3Client = new Client({

Check failure on line 15 in tests/s3/minio.integration.test.ts

View workflow job for this annotation

GitHub Actions / Linux

tests/s3/minio.integration.test.ts

InvalidEndpointError: Invalid endPoint : minio:9000 ❯ new TypedClient node_modules/minio/dist/esm/internal/client.ts:235:13 ❯ new Client node_modules/minio/dist/esm/minio.js:46:8 ❯ tests/s3/minio.integration.test.ts:15:22
endPoint: s3Host,
endPoint: parsedHostUrl.host,
accessKey: s3Access,
secretKey: s3Secret,
useSSL: false,
useSSL: parsedHostUrl.protocol === "https:",
pathStyle: true,
region: "us-east-1"
});
Expand All @@ -27,7 +28,7 @@ describe("S3 Provider - Integration", () => {
bucketName: bucketName,
parameters: {
useMinioSdk: "true",
endpoint: s3Host,
endpoint: parsedHostUrl.host,
disableHostPrefix: "true",
forcePathStyle: "true"
}
Expand Down

0 comments on commit b3ea738

Please sign in to comment.