Fix running_taskruns metric overcounting TaskRuns with no condition#9485
Open
bot4us wants to merge 2 commits intotektoncd:mainfrom
Open
Fix running_taskruns metric overcounting TaskRuns with no condition#9485bot4us wants to merge 2 commits intotektoncd:mainfrom
bot4us wants to merge 2 commits intotektoncd:mainfrom
Conversation
Replace !tr.IsDone() with an explicit nil + ConditionUnknown check so that newly created TaskRuns (before their first reconcile) are no longer counted as running. This aligns with the pipelinerunmetrics behavior and eliminates the inconsistency where sub-metrics were gated on ConditionUnknown while the top-level count was not. Fixes tektoncd#9438 Made-with: Cursor
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
size/M
Author
|
/kind bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace !tr.IsDone() with an explicit nil + ConditionUnknown check so that newly created TaskRuns (before their first reconcile) are no longer counted as running. This aligns with the pipelinerunmetrics behavior and eliminates the inconsistency where sub-metrics were gated on ConditionUnknown while the top-level count was not.
Fixes #9438
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes