Skip to content

Conversation

@kaur-mananjeet
Copy link
Contributor

After firmware upgrade is complete and user is asked to close the terminal, kic executable closes. In case user hits enter when asked to close the terminal, stack trace is not printed and executables are closed.

@kaur-mananjeet kaur-mananjeet self-assigned this Nov 24, 2025
@kaur-mananjeet kaur-mananjeet requested a review from a team as a code owner November 24, 2025 04:42
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Code Coverage

Package Line Rate Health
kic-visa/src/process.rs 0%
kic-lib/src/interface/connection_addr.rs 57%
kic-debug-visa/src/main.rs 0%
kic-lib/src/instrument/mod.rs 0%
kic-lib/src/instrument/authenticate.rs 17%
instrument-repl/src/state_machine.rs 61%
kic-discover/src/ethernet/mod.rs 0%
kic-lib/src/instrument/language.rs 25%
kic-visa/src/main.rs 0%
kic-lib/src/model/ki2600.rs 93%
kic-debug-visa/src/debugger/mod.rs 0%
kic-lib/src/protocol/raw.rs 67%
kic-lib/src/model/versatest.rs 78%
kic-lib/src/instrument/script.rs 100%
kic-discover-visa/src/lib.rs 0%
instrument-repl/src/resources/mod.rs 100%
instrument-repl/src/repl.rs 0%
kic-debug/src/debugger/mod.rs 0%
kic-lib/src/protocol/mod.rs 35%
kic-debug/src/resources/mod.rs 100%
kic-lib/src/protocol/visa.rs 0%
kic/src/main.rs 0%
kic-debug/src/main.rs 0%
kic-discover-visa/src/instrument_discovery/mod.rs 0%
instrument-repl/src/instrument.rs 85%
kic-discover/src/main.rs 0%
kic-discover-visa/src/ethernet/mod.rs 0%
kic-debug-visa/src/resources/mod.rs 100%
kic-lib/src/protocol/stb.rs 31%
kic-lib/src/instrument/abort.rs 0%
kic-lib/src/interface/mod.rs 0%
kic/src/process.rs 0%
kic-lib/src/instrument/reset.rs 0%
kic-discover-visa/src/visa.rs 0%
kic-lib/src/instrument/login.rs 0%
kic-discover/src/process.rs 0%
kic-discover-visa/src/main.rs 0%
kic-lib/src/model/ki3700.rs 93%
kic-lib/src/model/tti.rs 92%
instrument-repl/src/tsp_error.rs 0%
kic-discover/src/lib.rs 0%
kic-lib/src/model/mod.rs 20%
kic-lib/src/interface/async_stream.rs 0%
kic-discover/src/instrument_discovery/mod.rs 0%
kic-debug/src/process.rs 0%
kic-lib/src/instrument/info.rs 55%
Summary 41% (4005 / 9801)

pavannarayana
pavannarayana previously approved these changes Nov 24, 2025
Copy link
Member

@esarver esarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGELOG

@kaur-mananjeet kaur-mananjeet merged commit 3289802 into main Nov 25, 2025
16 checks passed
@kaur-mananjeet kaur-mananjeet deleted the task/clean-closure-of-kic-exe branch November 25, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants