Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/tsp 464 bump version #35

Merged
merged 4 commits into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
Security -- in case of vulnerabilities.
-->

## [0.16.4]

### Changed
- "TSP: Open Terminal" command has been renamed to "TSP: Connect"
- "Open Terminal" should just open the terminal, not just in the command palette (TSP-464)

### Fixed
- Send script to all terminals is failing(TSP-598)
- **tsp-toolkit-kic-cli:** Renamed update to upgrade for firmware upgrade in CLI arguments (TSP-741)

## [0.16.1]

### Fixed
Expand Down Expand Up @@ -113,7 +123,8 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
- Feature to retrieve TSP-Link network details

<!-- Version Comparison Links -->
[Unreleased]: https://github.com/tektronix/tsp-toolkit/compare/v0.16.1...HEAD
[Unreleased]: https://github.com/tektronix/tsp-toolkit/compare/v0.16.4...HEAD
[0.16.4]: https://github.com/tektronix/tsp-toolkit/releases/tag/v0.16.4
[0.16.1]: https://github.com/tektronix/tsp-toolkit/releases/tag/v0.16.1
[0.15.3]: https://github.com/tektronix/tsp-toolkit/releases/tag/v0.15.3
[0.15.2]: https://github.com/tektronix/tsp-toolkit/releases/tag/v0.15.2
Expand Down
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"publisher": "Tektronix",
"displayName": "[Beta] Keithley TSP Toolkit",
"description": "VSCode extension for Keithley Instruments' Test Script Processor",
"version": "0.16.1",
"version": "0.16.4",
"icon": "./resources/TSP_Toolkit_128x128.png",
"galleryBanner": {
"color": "#EEEEEE",
Expand Down Expand Up @@ -325,7 +325,7 @@
},
"dependencies": {
"@tektronix/keithley_instrument_libraries": "0.16.0",
"@tektronix/kic-cli": "0.16.1",
"@tektronix/kic-cli": "0.16.2-0",
"@tektronix/web-help-documents": "0.15.3",
"@types/cheerio": "^0.22.35",
"cheerio": "^1.0.0-rc.12",
Expand Down
7 changes: 3 additions & 4 deletions src/communicationmanager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,8 @@ export class CommunicationManager {
// Sends script to terminal
private async sendScript(_e: unknown) {
const uriObject = _e as vscode.Uri
const filePath = '"' + uriObject.fsPath + '"'
const text = ".script " + filePath
await this.handleSendTextToTerminal(text).then(() => {
const filePath = `.script "${uriObject.fsPath}"`
await this.handleSendTextToTerminal(filePath).then(() => {
void vscode.window.showInformationMessage(
"Sending script to terminal"
)
Expand All @@ -70,7 +69,7 @@ export class CommunicationManager {
*/
private sendScriptToAllInstruments(_e: unknown) {
const uriObject = _e as vscode.Uri
const filePath = `.script ${uriObject.fsPath}`
const filePath = `.script "${uriObject.fsPath}"`
const kicTerminals = vscode.window.terminals.filter((t) => {
const to = t.creationOptions as vscode.TerminalOptions
return to?.shellPath?.toString() === EXECUTABLE
Expand Down
Loading