-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CORS_ENABLED env var for docker-compose #620
Conversation
Thank for the contribution! In order to complete the PR, please take into account the following feedback:
|
I added the entry regarding CORS_ENABLED in the CHANGES_NEXT_RELEASE. I also added a new line in the running.md (line 104) to define the CORS_ENABLED attribute. |
Ok Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
CHANGES_NEXT_RELEASE
Outdated
@@ -1 +1 @@ | |||
- Set Nodejs 14 as minimum version in packages.json (effectively removing Nodev12 from supported versions) | |||
- Add: CORS_ENABLED env var (boolean) to enable the cors configuration (of config.js file) in your docker image (#608) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add: CORS_ENABLED env var (boolean) to enable the cors configuration (of config.js file) in your docker image (#608) | |
- Add: CORS_ENABLED env var (boolean) to enable the cors configuration (of config.js file) in your docker image (#608) | |
- Set Nodejs 14 as minimum version in packages.json (effectively removing Nodev12 from supported versions) |
This seems to be a wrongly solved merge conflict. You shouldn't delete existing lines in CHANGES_NEXT_RELEASE file, just add yours.
Sorry, I didn't know! I added the first line in CHANGES_NEXT_RELEASE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Added the CORS_ENABLED environment variable as described in the issue 608.
Please, check where it is necessary to update the doc (i.e. https://github.com/telefonicaid/fiware-sth-comet/blob/master/doc/manuals/running.md) to add this new env var.
A usage can be:
I don't know if it can be included in the test scripts, I only changed the sthConfiguration.js file in the lib/configuration folder.