Fix bugs in InstallCommand and ProcessInboundPhoto for proper message handling #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the installCommand file, adding the message.photo configuration option was not handled properly due to extra space. This commit fixes the bug by removing the extra space.
In the ProcessInboundPhoto file, the downloadFile method was not properly accepting the file_id as the first input parameter, resulting in errors when attempting to download photos from the Telegram server. This commit fixes the bug.
irazasyed
reviewed
Mar 5, 2025
| // Download the largest image to the storage/app directory. | ||
| $photo = collect($update['message']['photo'])->last(); | ||
| $bot->downloadFile($photo, storage_path('app/photos')); | ||
| $bot->downloadFile($photo['file_id'], storage_path('app/photos')); |
There was a problem hiding this comment.
File ID will be retrieved automatically if it's a response object, this is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.