Update dot-net-core-support.md #1833
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the .NET Core support documentation for Telerik Reporting, focusing on improving grammar, punctuation, and clarity throughout the documentation. The changes primarily involve adding missing commas, correcting article usage, and enhancing sentence structure for better readability.
Key Changes
- Added missing commas after introductory phrases and in compound sentences
- Corrected article usage (adding "a" before "SkiaSharp-based graphics engine")
- Fixed grammatical issues and improved sentence flow
- Added a new section for Windows Docker Container with System.Drawing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ## Sample Projects | ||
|
|
||
| Telerik Reporting ships with ready-made .NET examples demonstrating how to show the sample reports in an ASP.NET Core, WinForms, and WPF application. The ASP.NET Core demo also shows how to inject an `appsettings.json` configuration file to the controller and how to initialize a WebHostBuilder so it runs under Windows and Linux. | ||
| Telerik Reporting ships with ready-made .NET examples demonstrating how to show the sample reports in an ASP.NET Core, WinForms, and WPF application. The ASP.NET Core demo also shows how to inject an `appsettings.json` configuration file into the controller and how to initialize a WebHostBuilder so it runs under Windows and Linux. |
There was a problem hiding this comment.
[nitpick] The phrase 'into the controller' should be 'to the controller' to maintain consistency with the original technical meaning. The injection pattern typically refers to injecting dependencies to a controller rather than into it.
Copilot uses AI. Check for mistakes.
| With [2024 Q2 (18.1.24.514)](https://www.telerik.com/support/whats-new/reporting/release-history/progress-telerik-reporting-2024-q2-18-1-24-514), we started distributing sample Docker files for deploying the Telerik Reporting Web Examples for .NET with Skia Sharp Graphics Engine on Linux Docker containers. The distributed Docker files should be used to build the Docker image from the terminal. They are unsuitable for use with Visual Studio due to the specific folder structure of the Reporting examples. The Visual Studio projects use, by default, TRDP reports deployed in a folder that cannot be accessed by the Docker file when run from Visual Studio. | ||
|
|
||
| The Docker files may be found in the folder of the corresponding project. For example, the `Docklerfile` for the .NET 8 Telerik Reporting REST Service project with enabled CORS may be found by default in `C:\Program Files (x86)\Progress\Telerik Reporting {{site.suiteversion}}\Examples\CSharp\.NET {{site.mindotnetversion}}\ReportingRestServiceCorsDemo`. The Docklerfile starts with instructions for building the image and running the Docker container. Replace the placeholders in the curly brackets with the corresponding details: __TelerikNuGetApiKey__, __Telerik Reporting Installation Folder__, and __Connection String to AdventureWorks Database Accessible From the Docker Container__. Here is a sample content of the file. The deployed Reporting REST Service project with enabled CORS will run on `localhost:4040` in the browser: | ||
| The Docker files may be found in the folder of the corresponding project. For example, the `Dockerfile` for the .NET 8 Telerik Reporting REST Service project with enabled CORS may be found by default in `C:\Program Files (x86)\Progress\Telerik Reporting {{site.suiteversion}}\Examples\CSharp\.NET {{site.mindotnetversion}}\ReportingRestServiceCorsDemo`. The Dockerfile starts with instructions for building the image and running the Docker container. Replace the placeholders in the curly brackets with the corresponding details: __TelerikNuGetApiKey__, __Telerik Reporting Installation Folder__, and __Connection String to AdventureWorks Database Accessible From the Docker Container__. Here is a sample of the file's content. The deployed Reporting REST Service project with enabled CORS will run on `localhost:4040` in the browser: |
There was a problem hiding this comment.
There's an inconsistency in the filename reference. The text mentions 'Docklerfile' in the original (which appears to be a typo), but it's correctly updated to 'Dockerfile' in most places. However, ensure all references consistently use 'Dockerfile' throughout the documentation.
Copilot uses AI. Check for mistakes.
No description provided.