Skiareshape draw #16
Merged
Skiareshape draw #16
+584
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add library path setup for test execution using the same logic as gst-env.py to ensure tests can find required shared libraries (particularly on macos) - Support cargo-nextest when available for better test output - Split test execution per package for better granularity in meson test reports - Add --build-tests flag to build test binaries during plugin compilation - Fix logfile path generation when depfile is not provided This ensures that Rust plugin tests run correctly with proper library paths and provides better integration with the meson test infrastructure. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2583>
Adds a "draw" signal that allows custom drawing operations on the Skia canvas after reshape processing completes. The signal provides: - BufferRef: Access to the buffer being processed - VideoInfo: Video format information - SkiaCanvas: Canvas for custom drawing operations - SkiaContext: Optional GPU context for hardware acceleration The signal is emitted after clipping rounded corners, so custom drawing will be affected by the border-radius property. Also fixes a bug where border radius clipping was incorrectly applied even when border_radius = 0, which prevented custom drawing from being visible. Changes include: - New GBoxed wrapper types for passing Rust types through GObject signals - Signal definition with RUN_LAST flag for synchronous execution - Updates to both CPU (reshape) and GL (reshapegl) implementations - Comprehensive test coverage validating signal emission and drawing - Re-export of boxed types at crate level for public API This enables applications to perform custom Skia drawing without requiring a separate gloverlay element in the pipeline.
We do not rely on any EGL specific API anymore
When skiareshape is used solely for custom drawing via the "draw" signal without any geometric transformations (crop/padding/border-radius), we could implement transform_ip to avoid unnecessary buffer copies. This would improve performance for cases where only overlays are being drawn on top of the video.
Skia milestone 140 deprecated methods taking GrDirectContext* in favor of methods taking SkRecorder*. This updates the skia plugin to use the new Recorder-based API: - Use DirectContext.as_recorder() to get a Recorder for validation and subsetting operations - Image.is_valid() now takes Option<&mut dyn Recorder> instead of Option<&mut DirectContext> - Image.make_subset() now takes Option<&mut dyn Recorder> instead of Option<&mut DirectContext> The DirectContext is still used for actual GPU operations (creating textures, surfaces, flushing), but validation and subsetting now use the Recorder abstraction as part of Skia's transition to support both Ganesh and Graphite backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.