Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#511 | Update teloscan analytics #512

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Jan 8, 2024

Fixes #511

Description

This PR updates how Fathom analytics is used to avoid a deprecated method, and adds support for tracking Brave wallet logins

Test scenarios

  • this PR will need to be tested locally in the brave browser. run git fetch --all && git checkout 511-analytics-updates && yarn && yarn dev
  • open ChainStore.ts and paste this at the top of the function trackAnalyticsEvent: console.log('tracking fathom event with name ' + eventName);
  • open your browser to http://localhost:8080
  • open your browser dev console
  • in the dev console, filter messages by fathom (so you can see fathom logging easier)
  • if you are using brave browser ad blocking or any ad blocker, disable it
  • if you have already connected your Metamask to localhost, disconnect it from the metamask menu
  • click "Connect wallet" in Teloscan
  • click Metamask
    • you should see an event fire with the Login Started name
  • connect with metamask
    • you should see events fire with Login Successful and Login Successful - Metamask names
  • log out
  • click "Connect Wallet"
  • click Wallet Connect
    • you should see an event fire with the Login Started name
  • proceed to log in with walletconnect using your phone
    • you should see events fire with Login Successful and Login Successful - WalletConnect names
  • log out
  • disable metamask and any other wallets
  • enable your brave wallet in the brave settings
  • login to teloscan using brave
    • you should see events fire with Login Successful and Login Successful - Brave names

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit e43f770
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/659c6c7dc52528000884aea3
😎 Deploy Preview https://deploy-preview-512--teloscan-stage.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit e43f770
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/659c6c7d47277e000704c77f
😎 Deploy Preview https://deploy-preview-512--dev-mainnet-teloscan.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ezra-sg ezra-sg marked this pull request as ready for review January 8, 2024 21:43
@ezra-sg ezra-sg self-assigned this Jan 8, 2024
@ezra-sg ezra-sg changed the title #511 | Update analytics #511 | Update teloscan analytics Jan 8, 2024
@donnyquixotic donnyquixotic merged commit 7c8d6f1 into dev Jan 9, 2024
9 checks passed
@donnyquixotic donnyquixotic deleted the 511-analytics-updates branch January 9, 2024 17:08
@donnyquixotic donnyquixotic mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update teloscan analytics
2 participants