Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#875 | bug - contract tab shown for factory-built contracts #880

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Nov 20, 2024

Fixes #875

Description

In the case of factory-built contracts, sometimes we don't count with the name or the abi. But we have the creationInfo and that's enough to consider a contract valid.

Test scenarios

factory-built contract: 0xe0740E654B33550712E192c00C857D64Ce675Af3

image

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit 14647ef
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/673df96d60c0010008162837
😎 Deploy Preview https://deploy-preview-880--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 14647ef
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/673df96daaf15b0008be33eb
😎 Deploy Preview https://deploy-preview-880--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 14647ef
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/673df96d7a6e020008014812
😎 Deploy Preview https://deploy-preview-880--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo self-assigned this Nov 20, 2024
@Viterbo Viterbo force-pushed the 875-bug--contract-tab-is-not-shown-on-address-page-2 branch from f7c3d44 to 14647ef Compare November 20, 2024 14:59
@pmjanus pmjanus merged commit 6d0cd72 into dev Nov 21, 2024
13 checks passed
@pmjanus pmjanus deleted the 875-bug--contract-tab-is-not-shown-on-address-page-2 branch November 21, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants