Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#897 | disabled query button fixed for simple read functions #898

Merged

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Dec 8, 2024

Fixes #897

Description

There was an issue with the simple read functions on contracts that caused the query button to remain disabled when no parameters were required. This PR resolves that problem, allowing you to use the query button for no-parameter read functions on contracts.

Additionally, this PR completely removes the Antelope name (the old name for the library we were building) and replaces it with the term 'core.'

Test scenarios

  1. Go to this contract page
  2. Change to read tab
  3. open any function expansion-item component
  4. press query button
  5. You should get the result displayed as shown in the screen capture.

image

@Viterbo Viterbo self-assigned this Dec 8, 2024
Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit c3a8f30
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/675609c2d24ae0000814637a
😎 Deploy Preview https://deploy-preview-898--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit c3a8f30
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/675609c20314e3000811eb5d
😎 Deploy Preview https://deploy-preview-898--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit c3a8f30
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/675609c26c0aac00086086c8
😎 Deploy Preview https://deploy-preview-898--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo changed the title desabled query button fixed for simple read functions disabled query button fixed for simple read functions Dec 8, 2024
@Viterbo Viterbo changed the title disabled query button fixed for simple read functions #897 | disabled query button fixed for simple read functions Dec 8, 2024
@pmjanus pmjanus merged commit 2980626 into dev Dec 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants