Remove IngressRouteTCP and IngressRoute for Stopped Instances
#1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
ianstanton
commented
Dec 12, 2024
| @@ -196,7 +197,48 @@ async fn apply_ingress_route_tcp( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| async fn delete_ingress_route_tcp( | |||
| pub async fn delete_ingress_route( | |||
There was a problem hiding this comment.
This can be DRY'd up with the function below
ianstanton
commented
Dec 12, 2024
| namespace, | ||
| cdb_name, | ||
| resources.items.len(), | ||
| std::any::type_name::<R>(), |
There was a problem hiding this comment.
Include resource type so we can see what resource we're looking for.
ianstanton
commented
Dec 12, 2024
| @@ -697,6 +697,7 @@ mod test { | |||
| client: Client, | |||
| cdb_name: &str, | |||
| namespace: &str, | |||
| list_params: &ListParams, | |||
There was a problem hiding this comment.
Pass in ListParams for flexibility
ianstanton
commented
Dec 12, 2024
|
|
||
| #[tokio::test] | ||
| #[ignore] | ||
| async fn functional_test_hibernate_with_app_service() { |
There was a problem hiding this comment.
New test for hibernate + app service
ianstanton
requested review from
nhudson,
ChuckHend and
vrmiguel
as code owners
ChuckHend
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IngressRouteTCPfor Stopped Instances #1058, which removesIngressRouteTCPresources for stopped instances.IngressRouteresources for stopped instances. When these are left in place,traefiklogs the following error:list_paramsparameter tolist_resourcesfor flexibility when listing resources in tests.