-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only reconcile ing tcp for apps with tcp route #1079
Conversation
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
Looking into a test failure in |
There are some changes that improve test flakiness in #1081. Going to pull that in once it is merged and see how things look. Though this failure doesn't seem to be a flake 🤔 |
I think I see the issue here. This test was only passing because we were incorrectly deleting IngressRouteTCPs. That bug has since been fixed and we need to apply an update in this code |
I closed it, but will refactor the PR a bit to make it a bit more clean. |
@ianstanton you should be able to merge upstream once I merge #1089 |
Signed-off-by: Ian Stanton <ian@tembo.io>
Signed-off-by: Ian Stanton <ian@tembo.io>
reconcile_ingress_tcp
in app services. If any app service had a route with"ingressType": "tcp"
, we would createIngressRouteTCP
resources for all app services in the spec.appServices
definition would create anIngressRouteTCP
for bothfdb-api
andpostgrest
.fdb-api
because it has a route with"ingressType": "tcp"
, but we should not create one forpostgrest