Only delete ingress objects if stopped #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Stanton <ian@tembo.io>
ianstanton
requested review from
nhudson,
ChuckHend and
vrmiguel
as code owners
nhudson
approved these changes
Dec 17, 2024
ChuckHend
approved these changes
Dec 17, 2024
Signed-off-by: Ian Stanton <ian@tembo.io>
ianstanton
commented
Dec 17, 2024
| @@ -4369,19 +4369,19 @@ CREATE EVENT TRIGGER pgrst_watch | |||
| assert!(service_items.is_empty()); | |||
| // should be no Services | |||
|
|
|||
| // ingress must be gone | |||
| // There should be 1 IngressRoute left (metrics) | |||
There was a problem hiding this comment.
These assertions were checking for 0 IngressRoutes and 0 IngressRouteTCPs. They were being deleted and re-created before introducing this fix. We expect 1 of each to be present.
nhudson
added a commit
that referenced
this pull request
Dec 17, 2024
* main: Only delete ingress objects if stopped (#1082)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap ingress deletion logic in condition check for
cdb.spec.stop. Without this, ingress objects were deleted and re-created for all instances.