Correct the secret name where the URL encoded connection string is located #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrmiguel
approved these changes
Jan 3, 2025
ChuckHend
reviewed
Jan 3, 2025
| | EnvVarRef::EncodedReadWriteConnection => { | ||
| encoded_connection_secret_name.clone() | ||
| } | ||
| _ => apps_connection_secret_name.clone(), |
There was a problem hiding this comment.
Is it not safe to always use the url encoded secret name?
There was a problem hiding this comment.
most likely, but I didn't want to risk breaking anything. There are several places in Mahout that encode passwords using the current secret.
ChuckHend
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the #1114 change, the name of the kubernetes secret is wrong where the URL encoded connection string lives.
This PR fixes the location of the secret.