Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--set #485

Merged
merged 13 commits into from
Jan 22, 2024
Merged

--set #485

merged 13 commits into from
Jan 22, 2024

Conversation

joshuajerin
Copy link
Contributor

@joshuajerin joshuajerin commented Jan 17, 2024

Closes Linear-2724

We are adding --set subcommand inside apply to temporarily set user's specifying setting to that value.

To test it out locally, you can run "tembo apply --set (instance name).(instance setting) = (instance value).
There is a folder inside Tembo-cli/examples/set for a example tembo.toml file

When tested locally, it changes the stack_type from "Standard" to "OLTP" in Docker as seen below.
Screenshot 2024-01-22 at 11 21 55

When tested in cloud, we give the command to change CPU from "1" to "2" as seen below with a Screenshot from mahout.
Screenshot 2024-01-22 at 11 26 25
Screenshot 2024-01-22 at 11 29 26

@joshuajerin joshuajerin marked this pull request as ready for review January 17, 2024 00:39
tembo-cli/src/main.rs Outdated Show resolved Hide resolved
@shahadarsh
Copy link
Contributor

@joshuajerin Great progress. A few points:

  • Can you add a test similar to the one you added for merge?
  • In the PR description, can you explain the steps you took to test it locally and against the cloud? If you can specify the outputs there that would be great.
  • Because of my merge earlier today you will have to fix the merge conflicts (sorry). You will see I moved the tests from main.rs to apply.rs because it's testing a function in apply.rs

@joshuajerin joshuajerin enabled auto-merge (squash) January 22, 2024 16:36
Copy link
Contributor

@shahadarsh shahadarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Looks good to me. If you can also bump the version in Cargo.toml to 0.16.0

@joshuajerin joshuajerin merged commit 3875a1a into main Jan 22, 2024
7 checks passed
@joshuajerin joshuajerin deleted the set_apply branch January 22, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants