-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--set #485
Merged
Merged
--set #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajerin
requested review from
shahadarsh,
vrmiguel,
DarrenBaldwin07 and
sjmiller609
as code owners
January 17, 2024 00:39
shahadarsh
reviewed
Jan 17, 2024
shahadarsh
reviewed
Jan 17, 2024
shahadarsh
reviewed
Jan 17, 2024
shahadarsh
reviewed
Jan 17, 2024
shahadarsh
reviewed
Jan 17, 2024
@joshuajerin Great progress. A few points:
|
shahadarsh
reviewed
Jan 22, 2024
shahadarsh
reviewed
Jan 22, 2024
shahadarsh
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Looks good to me. If you can also bump the version in Cargo.toml to 0.16.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Linear-2724
We are adding --set subcommand inside apply to temporarily set user's specifying setting to that value.
To test it out locally, you can run "tembo apply --set (instance name).(instance setting) = (instance value).
There is a folder inside Tembo-cli/examples/set for a example tembo.toml file
When tested locally, it changes the stack_type from "Standard" to "OLTP" in Docker as seen below.
When tested in cloud, we give the command to change CPU from "1" to "2" as seen below with a Screenshot from mahout.