Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BOOLEAN to LITERAL #128

Merged
merged 1 commit into from
May 28, 2024
Merged

Rename BOOLEAN to LITERAL #128

merged 1 commit into from
May 28, 2024

Conversation

bogdancondorachi
Copy link
Contributor

@bogdancondorachi bogdancondorachi commented May 24, 2024 •
edited
Loading

Additional to #123

Renaming BOOLEAN token into LITERAL to represent a wider range of fixed values like (true, false, null, yes, no, undefined etc.)

@coveralls
Copy link

coveralls commented May 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9222603186

Details

  • 8 of 9 (88.89%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.326%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Languages/Python/Patterns/PyLogicalValuePattern.php 0 1 0.0%
Totals Coverage Status
Change from base Build 9207831203: 0.0%
Covered Lines: 1550
Relevant Lines: 1626
💛 - Coveralls

@brendt brendt merged commit 1da0f76 into tempestphp:main May 28, 2024
4 checks passed
@bogdancondorachi bogdancondorachi deleted the token-rename branch May 28, 2024 08:55
@brendt
Copy link
Member

brendt commented May 28, 2024

Tagged: https://github.com/tempestphp/highlight/releases/tag/2.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdancondorachi @coveralls @brendt